Closed ghost closed 1 year ago
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:
Coverage data is based on head (
df44995
) compared to base (49a2df9
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
We don't need to support Node.js 12 anymore. Can you please update the workflow at https://github.com/image-js/iobuffer/blob/main/.github/workflows/nodejs.yml#L32 to remove 12.x and add 18.x.
I see. Yes, I'll do in a sec. Done @targos.
IOBuffer.decodeText
IOBuffer.readUtf8
when no encoding is given (or whenutf-8
is given)Probably needs adjustments.
I am not sure what is the problem with Node 12x. If the tsconfig.target is changed to 2019, and run
nvm use 12
a different error appears: