search

image-rs / image-png

PNG decoding and encoding library in pure Rust
https://docs.rs/png
Apache License 2.0
364 stars 143 forks source link

20% performance regression from stable to git #541

Closed Shnatsel closed 2 hours ago

Shnatsel commented 2 hours ago

I'm seeing a large performance regression on https://github.com/fintelia/corpus-bench.git when I add this line to Cargo.toml:

png = { git = "https://github.com/image-rs/image-png.git" }

It happens both with and without the unstable feature.

Tested on png v0.17.14 for stable and 9020cd916c133387dfdc93fa33696aa8a27e42b2 for git using a corpus of random PNG images craped off the web

Shnatsel commented 2 hours ago

Wait, no, I re-tested with latest stable and the numbers are the same, now I have no idea what caused the drop compared to a few days ago.

Edit: I was using the wrong git repo for fdeflate, I'm dumb

Shnatsel commented 2 hours ago

Nope, I accidentally rolled back a 20% performance improvement, please disregard this