search

image-rs / image

Encoding and decoding images in Rust
Apache License 2.0
5.01k stars 619 forks source link

Wrong MSRV #2168

Closed cospectrum closed 8 months ago

cospectrum commented 8 months ago

Failed to compile using 1.67.1 rustc. The MSRV seems to be 1.70.0.

Expected

successful compilation

Actual behaviour

compilation failed

Reproduction steps

rustup install 1.67.1 && cargo new reproduce && cd reproduce && cargo add image && cargo +1.67.1 check
cospectrum commented 8 months ago

Perhaps dependencies are to blame. I noticed it during recent CI on imageproc

fintelia commented 8 months ago

Our CI checks with the MSRV version, but we use -Zminimal-version so that we pull in dependency versions with suitably old MSRVs

cospectrum commented 8 months ago

If you think this is the right approach, then that's okay.