image-rs / imageproc

Image processing operations
MIT License
755 stars 148 forks source link

Add generalizated convolution filter #520

Closed vsuryamurthy closed 6 months ago

vsuryamurthy commented 1 year ago

At the moment, there is only a filter3x3 available. I would like to add a function which is a generalization of filter3x3. Here is the PR: https://github.com/image-rs/imageproc/pull/517

willhansen commented 1 year ago

I thought it was odd I couldn't find this feature

theotherphil commented 6 months ago

This is available as Kernel::filter

ripytide commented 6 months ago

I think one of the reasons it might not have been spotted is because it is an associated method to the Kernel struct which is rather inconsistent as nearly all image operations are free-standing functions.

I think making that function free-standing would be a good idea.

theotherphil commented 6 months ago

I’d accept a PR to make that change.