search

image-rs / imageproc

Image processing operations
MIT License
735 stars 145 forks source link

Migrate to `ab_glyph` #541

Closed ciuncan closed 6 months ago

ciuncan commented 12 months ago

Fixes https://github.com/image-rs/imageproc/issues/540

There is a slight difference from previous implementation, that difference is obtained via below command (uses imagemagick) and added to truth folder as text_delta.png for inspection of this PR.

compare -compose difference tests/data/truth/text{_rusttype,_ab_glyph,_delta}.png

First commit contains the migration changes, second one is from cargo fmt.

fosskers commented 10 months ago

While we're at it, want to quickly bump the dependencies again? cargo upgrade (from cargo-edit) would do it.

ciuncan commented 10 months ago

Done :ok_hand:

fosskers commented 10 months ago

@theotherphil This should be good to go.

jayvdb commented 9 months ago

ping @theotherphil

jayvdb commented 6 months ago

@bvssvni , any chance you could review this PR?

bvssvni commented 6 months ago

Looks good to me! I am not sure why @theotherphil is not responding.

I opened up https://github.com/image-rs/imageproc/issues/547 just in case this has not been brought up.

theotherphil commented 6 months ago

Thanks for the PR and sorry for the slow response.