Closed Morgane55440 closed 4 months ago
Please can you run cargo fmt on your PR - formatting is checked in the pre-commit tests.
Please can you run cargo fmt on your PR - formatting is checked in the pre-commit tests.
done - just learned cargo fmt is a thing today
After inlining the unnecessary wrapper functions this looks good to me, thanks!
done !
Thanks!
this PR has been made following the issue #314 : Implement L2 Norm for morphology transforms
this PR seeks to integrate the L2 Norm for morphology operation, by expanding the
Norm
Enum to include L2, and updating all the functions which use this Enum to support the change. before :after:
on top of adding tests for the new norm, this PR also adds a couple tests for the other norms, in particular when
erode
anddilate
are called with a distancek
of 0.