search

image-rs / imageproc

Image processing operations
MIT License
735 stars 145 forks source link

Added `Miri` to `CI` #573

Closed cospectrum closed 4 months ago

cospectrum commented 4 months ago

I've separated all the tests and benchmarks where it makes sense. benches are ignored.

UB detected in nalgebra (Svd::try_new) and rayon (if feature is enabled), they are ignored.

theotherphil commented 4 months ago

@cospectrum as there’s been a burst of activity in this repo recently and your change touches a lot of files, let’s merge this after fixing the current merge conflict rather.

cospectrum commented 4 months ago

@theotherphil Conflict fixed, benches moved.

cospectrum commented 4 months ago

Note: we want to ignore benches because they are slow, not because they don't pass the Miri check.

theotherphil commented 4 months ago

@cospectrum is this good to go or do you have more changes pending for this PR?

cospectrum commented 4 months ago

@cospectrum is this good to go or do you have more changes pending for this PR?

You can merge

theotherphil commented 4 months ago

Thanks a lot for all the work you’re doing getting a proper testing suite in place.