Remove top-level clippy allows

image-rs / imageproc

Image processing operations

MIT License

758 stars 149 forks source link

Closed ripytide closed 6 months ago

ripytide commented 6 months ago

As discussed in https://github.com/image-rs/imageproc/pull/598#discussion_r1595832308 it might be a good idea to remove the top-level clippy allows and instead fix or allow lints on a case-by-case basis.

theotherphil commented 6 months ago

@ripytide most of these turned out to be totally unnecessary and a few more were easy to address.

Just two left now:

zero_prefixed_literal: I'm going to leave this lint disabled - the tests where we use zero-prefixed literals are more readable for using them
needless_range_loop: also quite a few uses left; I had a quick glance and the suggestions didn't obviously look to be improvements. I'd be happy to take a look at a PR that implements these suggestions but there's a risk I'd reject it

ripytide commented 6 months ago

needless_range_loop indeed seems contentious for this very array-based library. I think this issue is worth closing then since #617 is merged.