search

image-rs / imageproc

Image processing operations
MIT License
723 stars 144 forks source link

Switch from quickcheck to proptest #673

Open ripytide opened 3 weeks ago

ripytide commented 3 weeks ago

Fixes #626

cospectrum commented 3 weeks ago

You didn't disable miri on proptests

cospectrum commented 3 weeks ago

You can move them to local mod proptests

ripytide commented 3 weeks ago

Some utility functions were used in both normal tests and protests so I found it easier to just leave them together, but I suppose the best solution would be to add another shared utils module.

cospectrum commented 3 weeks ago

You can make some helpers from mod tests public

ripytide commented 2 weeks ago

Okay I've extracted all proptests into their own proptest modules which is definitely much nicer. Thanks @cospectrum for the pointer on making testing utilities pub.

cospectrum commented 1 week ago

Lgtm