Switch from quickcheck to proptest

image-rs / imageproc

Image processing operations

MIT License

758 stars 149 forks source link

Switch from quickcheck to proptest #673

Closed ripytide closed 3 months ago

ripytide commented 5 months ago

Fixes #626

cospectrum commented 4 months ago

You didn't disable miri on proptests

cospectrum commented 4 months ago

You can move them to local mod proptests

ripytide commented 4 months ago

Some utility functions were used in both normal tests and protests so I found it easier to just leave them together, but I suppose the best solution would be to add another shared utils module.

cospectrum commented 4 months ago

You can make some helpers from mod tests public

ripytide commented 4 months ago

Okay I've extracted all proptests into their own proptest modules which is definitely much nicer. Thanks @cospectrum for the pointer on making testing utilities pub.

cospectrum commented 4 months ago

Lgtm

theotherphil commented 3 months ago

A nice improvement, thanks. I’ll merge after the version issue is resolved.

cospectrum commented 3 months ago

It's because of dependencies, need to restart the job somehow. MSRV was increased in another PR

cospectrum commented 3 months ago

Details -> rerun, probably

theotherphil commented 3 months ago

Thanks!