image-rs / imageproc

Image processing operations
MIT License
758 stars 149 forks source link

Fix fast corner 9 algorithm #680

Closed LMJW closed 3 months ago

LMJW commented 3 months ago

Simple bug fix for FAST corner 9 algorithm.

Currently the fast corner 9 has a bug which causing some of the corner cannot be found. It looks the coordinate (P4& P8) was not mapped correctly in fast algorithm.

Below are the corner find without bug fix, some of the corner cannot be identified.
corner1

With the fix, all the corners can be found. corner2

LMJW commented 3 months ago

@ripytide @theotherphil @cospectrum Pls take a look when you have time and let me know if you have any comments :)

theotherphil commented 3 months ago

Thanks! It would be good to have some tests for this too.