Add fast blur algorithm

image-rs / imageproc

Image processing operations

MIT License

758 stars 149 forks source link

Add fast blur algorithm #683

Closed torfmaster closed 1 month ago

torfmaster commented 3 months ago

This PR is an alternative to https://github.com/image-rs/image/pull/2302 which adds the corresponding functionality in the image crate. It adds a fast approximation of Gaussian blur to this library.

It is an attempt to solve https://github.com/image-rs/image/issues/986. For the discussion discussion please refer to the PR in image until it is decided where the functionality will go.

ripytide commented 3 months ago

Thanks for opening another PR in this repo, I feel it is much better placed here. I don't have much knowledge about the specific blurring algorithm but I am happy to help with the code quality and maybe adding some benchmarks.

cospectrum commented 3 months ago

Some beautification is needed

torfmaster commented 3 months ago

@cospectrum thank you for your review comments. I am going to address them here and in my PR on the image crate. However, as long there is no decision whether the code will land in image or in imageproc I think it makes sense to continue the review in the PR for the image crate.

torfmaster commented 2 months ago

I just wanted to give a short status report (I also cross post this comment to https://github.com/image-rs/imageproc/pull/683)

I added a functional test showing (for an example) that the effect of fast_blur is close to the Gaussian blur implementation in this library
I added a benchmark that shows that fast blur is much faster than the current blur implementation
I think I addressed all code review comments

What would be the next steps?

cospectrum commented 1 month ago

merged into image

torfmaster commented 1 month ago

As the code is now in the image crate I will close this PR.