search

image-rs / jpeg-decoder

JPEG decoder written in Rust -- currently in maintenance mode
Apache License 2.0
148 stars 89 forks source link

The library is continuously tested with rust 1.24, but does not compile with rust 1.24 ! #102

Closed lovasoa closed 5 years ago

lovasoa commented 5 years ago

This library is continuously tested with rust 1.24 : https://github.com/kaksmet/jpeg-decoder/blob/master/.travis.yml

However, it currently does not compile with rust 1.24, because of a transitive dependency of rayon: https://travis-ci.org/kaksmet/jpeg-decoder/jobs/569851819

This causes all new pull requests to fail.

The problem is that Cargo.toml requires rayon= "1.0", which means ">=1.0<2.0.0" according to semver. And the current latest version of rayon to meet this requirement is 1.1.0, which requires rustc 1.28.0 or greater.

So there are two solutions:

  1. declare this library as requiring rustc >= 1.28.0 and updating .travis.yml (See PR #104)
  2. declare this library as requiring rustc >= 1.24.0 and updating Cargo.toml to specify ~1.0 instead of 1.0 as the version of rayon. (See PR #103)

I would be in favor of the first option, because a lot of the ecosystem already requires later rust versions.