search

image-rs / jpeg-decoder

JPEG decoder written in Rust
Apache License 2.0
148 stars 87 forks source link

fix clippy::into_iter_on_array error in decoder #116

Closed scottmcm closed 4 years ago

scottmcm commented 4 years ago

Rust is trying to add IntoIterator for arrays, which would break this. So might as well do it the way that's forward-compatible and also shorter.

scottmcm commented 4 years ago

CI failure doesn't look like the fault of this change:

failed to parse manifest at /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/cfg-if-0.1.10/Cargo.toml (All the other builds are fine)

CryZe commented 4 years ago

Looks like rayon isn't actually compatible with 1.28 anymore (due to some indirect dependency on the latest cfg-if).

lovasoa commented 4 years ago

Maybe Cargo.lock should be committed...

CryZe commented 4 years ago

Nah, you don't commit Cargo.lock for libraries. Then CI would pass but it would still fail to build on 1.28 for everyone depending on this crate. One solution is to depend on cfg-if =0.1.9, but that's probably just causing even more problems, so 1.28 should probably just be dropped.

LukasKalbertodt commented 4 years ago

@fintelia Do you think this fix can be released with a minor version bump (i.e. 0.1.17)? That would be really great, as jpeg-decoder caused 290 other crates to regress due to this. That's the second most regression caused after colored.

fintelia commented 4 years ago

@LukasKalbertodt 0.1.17 has now been published.