search

image-rs / jpeg-decoder

JPEG decoder written in Rust
Apache License 2.0
149 stars 87 forks source link

Remove feature gate on the std feature #213

Closed paolobarbolini closed 2 years ago

paolobarbolini commented 2 years ago

This improves the decode performance to up to 40%. Am I missing something? I wouldn't expect something this simple to add such a big change :sweat_smile:. The feature gate was added by #196, but no std feature is present in the Cargo.toml, so the multithreaded worker would never get used.

paolobarbolini commented 2 years ago

Force pushed to change email

fintelia commented 2 years ago

The alternative would be to add the std feature to Cargo.toml, but I think your way is a better option seeing as #196 points out that the crate cannot actually work without the standard library.

paolobarbolini commented 2 years ago

The alternative would be to add the std feature to Cargo.toml, but I think your way is a better option seeing as #196 points out that the crate cannot actually work without the standard library.

It could be added in 0.3.0