search

image-rs / jpeg-decoder

JPEG decoder written in Rust
Apache License 2.0
150 stars 87 forks source link

Collect unknown app1 data for further processing #267

Closed taavit closed 1 year ago

taavit commented 1 year ago

I'm working on project with some non-exif tags data, and only currently only exif tag from App(1) is collected. This PR collects all unknown app1 data, allowing user of library its further processing.

hfiguiere commented 1 year ago

I was looking at adding explicit XMP support, which is an APP1 segment starts with the string http://ns.adobe.com/xap/1.0/\0. This would probably conflict with this, but complement it too.

I wonder how we can proceed.

taavit commented 1 year ago

I was looking at adding explicit XMP support, which is an APP1 segment starts with the string http://ns.adobe.com/xap/1.0/\0. This would probably conflict with this, but complement it too.

I wonder how we can proceed.

Maybe app0/app1 could be separated from parsing jpeg data, then it could be more generic, and allows custom parser to be injected. Otherwise handling new custom app1 data will need changes to this library, or creating forks.