fix aarch64 AMP download links in dockerfile

imagegenius / docker-amp

CubeCoders AMP in a minimal docker container

https://hub.docker.com/r/imagegenius/amp

GNU General Public License v3.0

9 stars 3 forks source link

fix aarch64 AMP download links in dockerfile #8

Closed rekonnected closed 1 year ago

rekonnected commented 1 year ago

Fixed the links in Dockerfile.aarch64 so it now downloads and runs AMP properly on an ARM64 host. Tested on an M1 Mac and Oracle ARM VM.

ImageGeniusCI commented 1 year ago

I am a bot, here is the pushed image/manifest for this PR:

:2.4.4.0-pkg-1d3051e2-pr-8

hydazz commented 1 year ago

good work, thanks 😄

rekonnected commented 1 year ago

Happy to help, tried to do this once already for https://github.com/MitchTalmadge/AMP-dockerized/pull/140 (which involved a lot more work) but it was never merged, so I was happy to see all this needed was a link change.

Make sure to update the readme to reflect arm64 support is now good, I forgot to in my repo lol

hydazz commented 1 year ago

you had no issues in testing? this image uses alpine + glibc and would assume that it would not "just" work (it never does)

rekonnected commented 1 year ago

you had no issues in testing? this image uses alpine + glibc and would assume that it would not "just" work (it never does)

Ran through it a bit more in depth to double check it actually fully loads a proper java MC server, yep, it actually 'just' worked! Only catch I see so far may be inconsequential, the spec in the top bar isn't reading properly, idk if it actually uses that core count for anything other than an info display so it may not matter

(this is on the oracle 24G ARM server)

CleanShot 2023-06-28 at 01 29 05@2x