imageio / imageio-ffmpeg

FFMPEG wrapper for Python
BSD 2-Clause "Simplified" License
221 stars 50 forks source link

Aarch64 wheel is missing on PyPi #52

Closed odidev closed 3 years ago

odidev commented 3 years ago

I have seen that the aarch64 wheel is missing in Pypi. It will be useful if the aarch64 wheel is released as -

@almarklein Please let me know your interest in releasing aarch64 wheels. I can help in this. To start with can you please suggest the steps you are using for building the wheel.

almarklein commented 3 years ago

The process, which could improvements on many fronts:

So if there is a prebuild ffmpeg exe for aarch64, the process should be relatively straightforward.

Otherwise, do you think a CD workflow on Github actions could help here?

odidev commented 3 years ago

Arm64 binary is available in the form of tar here

I have followed the following steps to create and test the wheel for aarch64 in quay.io/pypa/manylinux2014_aarch64 docker-

Commit Link - https://github.com/odidev/imageio-ffmpeg/commit/e43f6e175393e689a745c485a5e629c553e13bc3

Could you please suggest further blockers in releasing the wheel for aarch64?

almarklein commented 3 years ago

Thanks for looking into this! In that case I don't think there are any blockers. We should add the new ffmpeg binary to imageio-binaries, and add the changes in the commit that you referenced. Could you please make a PR for these?

odidev commented 3 years ago

I have raised the PR here and also raised the PR for the binary in imageio-binaries

almarklein commented 3 years ago

Thanks! I just pushed a new release to pypi, so if all is well, you should be able to pip install imageio-ffmpeg on aarrch64.