ffmpeg not included in wheel for MacOS M1

imageio / imageio-ffmpeg

FFMPEG wrapper for Python

BSD 2-Clause "Simplified" License

233 stars 52 forks source link

ffmpeg not included in wheel for MacOS M1 #71

Open fayyazul-centaurlabs opened 2 years ago

fayyazul-centaurlabs commented 2 years ago

The readme on the main page states that ffmpeg is included with the install from pypi. However after installation I get the error:

RuntimeError: No ffmpeg exe could be found. Install ffmpeg on your system, or set the IMAGEIO_FFMPEG_EXE environment variable.

Not sure if it may be affecting it, but I am installing the package to a virtual environment.

almarklein commented 2 years ago

What OS are you on? It could be that we don't have wheels for yours, which causes pip to install the source version without ffmpeg included.

fayyazul-centaurlabs commented 2 years ago

I'm using an m1 mac so that's probably it. I saw that osx 10.9+ was supported but forgot to account for the m1 processor. I can download ffmpeg individually and the package works fine however.

almarklein commented 2 years ago

I updated the title to reflect the issue.

hmaarrfk commented 2 years ago

For what its worth, I think that imageio is quite flexible in how you can install ffmpeg. You can choose to install it from homebrew or conda (conda-forge) and imageio will attempt to find it.

If it can't find, and you are sure that you installed it correctly, there is also an environment variable that you can set to help imageio find the executable.

rbebb commented 2 years ago

The package works when I install ffmpeg through brew, but it would be great to have a wheel for Apple Silicon that includes the executable by default

anjos commented 1 year ago

A key question on this one would be how to find M1 runners that would allow the wheels for macOS+arm to be created before deployment. Of course, the repository imageio-binaries need to be equipped with the binaries for this platform.

Any ideas?

rbebb commented 1 year ago

@almarklein #83 does not solve the problem for this ticket. #83 only applies for Linux systems running on ARM (which is the Linux Docker container in that case). This ticket is about getting a native macOS ARM wheel

almarklein commented 1 year ago

@rbebb you're right, re-opened!

rbebb commented 1 year ago

@almarklein Thank you!

west-rynes commented 1 year ago

I did find static Apple Silicon FFMPEG binaries available here http://www.osxexperts.net

I was able to successfully download and test the static binary and it does work. Although it is not notarized, so I had to run xattr -c ffmpeg to bless it. Perhaps this binary could be included in the osx arm wheel so that it would work for users who need an easy way to get ffmpeg installed without using brew?

bigcat88 commented 5 months ago

Thank you very much for this project. Could you add binary wheels for macOS on m1? (Github already supports native macOS runners)

almarklein commented 5 months ago

I don't have a lot of free cycles, so if anyone is up for fixing this, this'd be the steps:

Add executable to https://github.com/imageio/imageio-binaries/tree/master/ffmpeg
Update _definitions.py
- Make sure the apple silicon platform is detected by get_platform().
- Add new exe file name to FNAME_PER_PLATFORM.
- Add entry to WHEEL_BUILDS.

rachelcenter commented 2 months ago

The readme on the main page states that ffmpeg is included with the install from pypi. However after installation I get the error:
RuntimeError: No ffmpeg exe could be found. Install ffmpeg on your system, or set the IMAGEIO_FFMPEG_EXE environment variable.
Not sure if it may be affecting it, but I am installing the package to a virtual environment.

exe is for windows. you're on a mac.