search

imageio / imageio-ffmpeg

FFMPEG wrapper for Python
BSD 2-Clause "Simplified" License
233 stars 52 forks source link

detect linux-aarch6 correctly for ffmpeg filenames #83

Closed kamikaz1k closed 1 year ago

kamikaz1k commented 1 year ago

When I was trying to run moviepy in a docker container (Docker for Mac on M1). I got the error: RuntimeError: No ffmpeg exe could be found. Install ffmpeg on your system, or set the IMAGEIO_FFMPEG_EXE environment variable.

Digging into the source of the issue, it was detecting the platform as linux64 instead of linuxaarch64. manually patching this on my machine fixed it, so I thought I would upstream it.

I think it'll resolve https://github.com/imageio/imageio-ffmpeg/issues/71

almarklein commented 1 year ago

Thanks, this is great! Could you please move the import to the top of the module please?

kamikaz1k commented 1 year ago

I also wanted to update the Contribution guidelines (to include how to test). Maybe I can do a follow up PR. Unless you're not interested; let me know.

almarklein commented 1 year ago

I also wanted to update the Contribution guidelines (to include how to test).

That'd be great. Yeah lets do in a new pr 👍

almarklein commented 1 year ago

Pypy build is hanging, but this is likely unrelated to this pr, so I'll merge!