imageio / imageio

Python library for reading and writing image data
https://imageio.readthedocs.io
BSD 2-Clause "Simplified" License
1.5k stars 296 forks source link

Test tests/test_ffmpeg.py::test_writer_pixelformat_size_verbose fails on conda-forge #911

Open anjos opened 1 year ago

anjos commented 1 year ago

For some reason, this test keeps failing on conda-forge: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=608588&view=logs&jobId=656edd35-690f-5c53-9ba3-09c10d0bea97&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d

The reason seems silly, however I cannot judge its pertinence:

>       assert "yuv420p" == W._meta["pix_fmt"]
E       AssertionError: assert 'yuv420p' == 'yuv420p(progressive)'
E         - yuv420p(progressive)
E         + yuv420p

To reproduce this error locally, just create a base environment with mamba-forge's ffmpeg installation and try it. Something like:

$ git clone <this-repo> && cd imageio
$ mamba create -n imageio-dev python=3.9 pillow numpy pip pytest psutil tifffile gdal astropy freeimage fsspec requests av imageio-ffmpeg
$ conda activate imageio-dev
(imageio-dev) $ pip install -e .
$ pytest -sv tests/test_ffmpeg.py::test_writer_pixelformat_size_verbose
...
>       assert "yuv420p" == W._meta["pix_fmt"]
E       AssertionError: assert 'yuv420p' == 'yuv420p(progressive)'
E         - yuv420p(progressive)
E         + yuv420p

C.f.: https://github.com/conda-forge/imageio-feedstock/pull/56

FirefoxMetzger commented 1 year ago

That's a good question. I will look into that once I am back from vacation, so either this weekend or during the coming week.