imagej / ImageJ

Public domain software for processing and analyzing scientific images
http://imagej.org
Other
556 stars 221 forks source link

Return values ignored #218

Closed scuniff closed 1 year ago

scuniff commented 1 year ago

https://github.com/imagej/imagej1/blob/master/ij/plugin/filter/Rotator.java

Return value from String.replaceAll() is ignored so the replacement is not seen.

            macroOptions.replaceAll(" interpolate", " interpolation=Bilinear");

should be

           macroOptions = macroOptions.replaceAll(" interpolate", " interpolation=Bilinear");

===================================================

https://github.com/imagej/ImageJ/blob/master/ij/Menus.java

Return value from String.trim() is ignored so the trim is not seen.

           command.trim();

should be

            command = command.trim();

This occurs twice

rasband commented 1 year ago

These bug fixes are in the ImageJ 1.54f4 daily build. The commit is at https://github.com/imagej/ImageJ/commit/f4913997eb238160031fe1bcbc309669d4384ce1.