search

imagej / ImageJ

Public domain software for processing and analyzing scientific images
http://imagej.org
Other
576 stars 227 forks source link

Image>Show Info... bug in some tags in DICOM images #245

Closed ramnoob closed 7 months ago

ramnoob commented 7 months ago

For some private tags, the Attribute Name may not be read properly and "---" may be displayed, or garbled text Value may be obtained.

ramnoob commented 7 months ago

Some public dicom tags are also not loaded correctly. This is partly due to poor class DicomDictionary in ij/plugin/DICOM.java. We have the latest version at DICOM Part 6: Data Dictionary in https://www.dicomstandard.org/current.

Also, for private tags, each manufacturer has published a DICOM Conformance Statement, and for pydicom, the DICOM Conformance Statement can be found in pydicom/src/pydicom/_private_dict.py is updated each time.

Shouldn't it be updated once again, at least for public tags?

ramnoob commented 7 months ago

For now, here is the ij/plugin/DICOM.java with a number of official tags added. https://github.com/ramnoob/ImageJ/blob/master/ij/plugin/DICOM.java It is working well.

It is very difficult to create a dictionary of private tags, and pydicom seems to have created one from the GDCM project's private dictionary.

rasband commented 7 months ago

The version of DICOM.java with added official tags is in the ImageJ 1.54j15 daily build. The commit is at https://github.com/imagej/ImageJ/commit/09d093cd8a47eaac7c0aed967093ce69d845face.