search

imagej / ij1-patcher

Extension points for ImageJ via runtime patching to support (limited) headless operation and ImageJ2's legacy layer
BSD 2-Clause "Simplified" License
5 stars 6 forks source link

MacAdapter moved into ij.plugin package #49

Open imagejan opened 4 years ago

imagejan commented 4 years ago

With https://github.com/imagej/imagej1/issues/71, the MacAdapter class lives now in ij.plugin.

We should check if any changes are required here in ij1-patcher in response to that.

rasband commented 4 years ago

I updated Fiji to the 1.53d59 daily build and did not notice any problems. I noticed that Fiji has customized the About Image and Preferences... commands in the Fiji menu. Where is the code that does this?

imagejan commented 4 years ago

I just noticed that this looks really ugly now, probably due to some per-channel autoscaling going on after the image is opened by SCIFIO:

image

I don't know where that code lives, we'll have to dig.

imagejan commented 4 years ago

Found it: the AboutImageJ class was fleshed out some time in 2012 and lives now here:

https://github.com/imagej/imagej-common/blob/ef16aed49df8791af95872530002df9606f96b59/src/main/java/net/imagej/app/AboutImageJ.java

rasband commented 4 years ago

Thanks! That was very helpful. Another question: were is AboutImageJ called from?

I noticed that the Help>About ImageJ window was also looking a little neglected so, in the 1.53d60 daily build, I made it larger and used an overlay to draw the text.