A bug within rebuild() caused any changes made to the channel ranges through setChannelRange() to be overridden upon the next call to rebuild(), which is problematic considering that rebuild() has to be called to update the DefaultDatasetView and see the changes that you want to make. This PR fixes this issue by only overriding the converters if there are none there in the first place (e.g. after the DefaultDatasetView was just created).
TODO:
Create a test proving that the converters are not overridden after calling rebuild().
Questions:
Are there any other circumstances in which we would want to reset the converters? Since autoscale is a public method it could be called by the user, but was there a reason that I am not familiar with that this decision to always override was made?
ctrueden
commented
5 years ago
A bug within
rebuild()caused any changes made to the channel ranges throughsetChannelRange()to be overridden upon the next call torebuild(), which is problematic considering thatrebuild()has to be called to update theDefaultDatasetViewand see the changes that you want to make. This PR fixes this issue by only overriding the converters if there are none there in the first place (e.g. after theDefaultDatasetViewwas just created).TODO:
rebuild().Questions:
autoscaleis a public method it could be called by the user, but was there a reason that I am not familiar with that this decision to always override was made?