search

imagej / imagej-common

ImageJ core data model
https://imagej.net/libs/imagej-common
BSD 2-Clause "Simplified" License
10 stars 16 forks source link

ImgLabeling converter: relax input from Img to RAI #94

Closed imagejan closed 2 years ago

imagejan commented 4 years ago

Replaces: Img -> ImgLabeling by: RandomAccessibleInterval -> ImgLabeling

We want this converter to handle any RandomAccessibleInterval, since otherwise a conversion request from RandomAccessibleInterval to ImgLabeling could be picked up by org.scijava.convert.DefaultConverter, resulting in an undesired (and possibly invalid) ImgLabeling created by its default constructor.

This is a follow-up pull request to #93.

See also this discussion on the forum.

imagejan commented 4 years ago

NB: needed to pin to imglib2 >= 5.9.0 to be able to use the new ImgView.wrap signature.

@ctrueden if this gets merged, we probably need to bump the major/minor version again, right?

imagejan commented 3 years ago

NB: needed to pin to imglib2 >= 5.9.0 to be able to use the new ImgView.wrap signature.

This pull request has been open long enough that we don't need this version pin any more, as the parent POM was updated in the meantime. I instead also removed the imglib2-roi version pinning from pom.xml, as the managed version is now higher than the one that was originally pinned.