imagej / imagej-launcher

The ImageJ native launcher
https://imagej.net/learn/launcher
BSD 2-Clause "Simplified" License
21 stars 23 forks source link

guess_java_version would fail for build versions > 255 #67

Open ctrueden opened 5 years ago

ctrueden commented 5 years ago

The guess_java_version method encodes the major, minor, patch and build versions into 8-bit chunks of a 32-bit int. If any of these values exceeds 255, it would overflow. In the case of the build version, nothing consumes it, so maybe this is not a problem. But filing here just in case.