search

imagej / imagej-launcher

The ImageJ native launcher
https://imagej.net/learn/launcher
BSD 2-Clause "Simplified" License
21 stars 23 forks source link

Fiji icon in the launcher #71

Closed haesleinhuepf closed 3 years ago

haesleinhuepf commented 3 years ago

Hi @ctrueden, and @hinerm ,

thanks a lot for working on the launcher!

As you're deploying the launcher these days anyway, would it be possible to make one which has a Fiji icon compiled into it?

At the moment, the program changes its icon on Windows when being pinned to the task bar. As many users pin the program there, they never see the Fiji logo. :-(

Before pinning: image

After pinning: image

I'm speculating this would change if this file would be replaced: https://github.com/imagej/imagej-launcher/blob/master/logo/ImageJ.ico

by this one: https://github.com/fiji/fiji/blob/master/images/fiji.ico

Let me know if I can help!

Cheers, Robert

ctrueden commented 3 years ago

ImageJ and Fiji are separate layers. The imagej-launcher repository must not contain the Fiji logo.

The plan is deploy the new ImageJ2 logo, with the Fiji logo still appearing as an extension icon in one corner of the splash screen. For the icon in the task bar, it would be the ImageJ2 logo always.

haesleinhuepf commented 3 years ago

Hey @hinerm , hey @ctrueden ,

I found a way to put the Fiji-icon on the taskbar in Windows without changing the launcher. All you need is fiji.ico fiji.ico.zip, e.g. in the images folder of Fiji. You can then create a shortcut / link and select the ico file as icon.

image

image

If you pin the shortcut afterwards to the taskbar, the Fiji program has the correct Fiji icon, also after starting the program.

image

Now the big question: to which repository shall I send the ico file and the lnk file as pull-request?

Thanks for your support!

Cheers, Robert

imagesc-bot commented 3 years ago

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/how-to-change-the-imagej-icon-to-the-fiji-icon/54211/2

imagesc-bot commented 3 years ago

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/how-to-change-the-imagej-icon-to-the-fiji-icon/54211/7

ctrueden commented 3 years ago

As discussed on the forum, it sounds like we'll just upload the .ico and .lnk files to the Java-8 update site directly. No need to commit them to a git repository for the moment.