search

imagej / imagej-launcher

The ImageJ native launcher
https://imagej.net/learn/launcher
BSD 2-Clause "Simplified" License
21 stars 23 forks source link

Repair jdk search logic #74

Closed hinerm closed 3 years ago

hinerm commented 3 years ago

Simplifies and fixed search logic for JDKs. Also adds GitHub Action tests to ensure cross-platform JDK discovery.

ctrueden commented 3 years ago

@hinerm Awesome! 🌟

I'm curious: does this incorporate all the work from trim-the-fat? (And if so: I'm curious why you were working from hinerm/master instead of trim-the-fat directly?) If trim-the-fat is complete, please delete that remote branch.

Thanks so much for your work on this!

Edit: Oh, because of GitHub Actions testing, right? Anyway, please still delete trim-the-fat—or if there is still unmerged work on it, rebase over the latest master. Thanks!