imagej / imagej-launcher

The ImageJ native launcher
https://imagej.net/learn/launcher
BSD 2-Clause "Simplified" License
21 stars 23 forks source link

Centralize Firewall Requirements #78

Open hinerm opened 3 years ago

hinerm commented 3 years ago

There was a report that updating to the latest (6.0.1) launcher on Windows 10 resulted in a new request for firewall access from javaw.exe, whereas in the past the access was via ImageJ-win64.exe.

Looking through my personal firewall records I found entries for both ImageJ-win64.exe and various Java runtimes.

So it seems that each Java version requires its own access, and if a Java version used with an old launcher had already been excepted, we would need to confirm that this actually is due to the launcher and not changing Java versions.

Locally, I when testing with ImageJ 1.x with an ImageJ.cfg, I get a firewall request for the JRE pointed to in the ImageJ.cfg.

I have not been able trigger a firewall request from either ImageJ-win64.exe or its bundled Java.

I also noticed that some ImageJ plugins may have their own firewall hits (3D viewer?).

So I would like to understand:

imagesc-bot commented 3 years ago

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/updated-imagej-launcher-java-bundles/44841/15

ctrueden commented 3 years ago

Might it depend on whether the launcher falls back to system Java? I believe that when it falls back to system Java, a new process is started, whereas when a Java library is dynamically linked, no new process.