ctrueden
commented
5 years ago @haesleinhuepf I very much appreciate you working on this! 🎉
However, I would appreciate if you would not self-merge things into imagej-legacy, unless you are interested in taking on the responsibility of the reviewer and maintainer roles for this component. Do you want that?
If not: I know it can be painful to wait for review from others, but core components, especially this one, can be very fiddly and it is important to have reviewer and maintainer eyes on every non-trivial PR.
For example, for this particular PR, I would advise not putting code in the service's initialize method, because every bit of code inside such methods slows down the creation of every single SciJava Context that includes that service. I make a concerted effort to use a lazy initialization pattern with services whenever possible, so that legwork to initialize things is only done on demand, rather than upfront.
haesleinhuepf
imagejan
Dear all,
with this change, the auto-completion pulldown in IJ macro becomes extensible using SciJavas Plugin/Service mechanism. This is necessary in order to support auto-completions for Macro Extensions.
FYI: An example implementation of a compatible plugin can be found here: https://github.com/haesleinhuepf/clearclij/blob/add_auto_completion_for_ij_macro/src/main/java/net/haesleinhuepf/imagej/macro/CLIJMacroExtensionAutoCompletionPlugin.java
Let me know if anything speaks against merging this or if you see potential for improvement.
Merry Christmas!
Cheers, Robert