imagej / imagej-legacy

ImageJ+ImageJ2 compatibility layer
https://imagej.net/libs/imagej-legacy
BSD 2-Clause "Simplified" License
16 stars 25 forks source link

Script editor autocompletion for "exit" #218

Closed miura closed 5 years ago

miura commented 5 years ago

Autocompletion in the scritpt editor for the function "exit" has a small bug. See the image below.

image

ctrueden commented 5 years ago

Looking at the functions.html, it appears that this exit function is the only one that has multiple invocations separated by an or outside the parentheses.

@haesleinhuepf Our priority should be to make sure that functions.html works as written automatically without tweaking, right? So that we can easily keep it updated as time goes on by dropping in new versions? If so, we need to write some special-case parsing for this odd case, right?

rasband commented 5 years ago

I updated the file at http://wsr.imagej.net/developer/macro/functions.html

so that exit and exit("error message") are separate entries.

<a name=exit></a>
<b>exit</b><br>
Terminates execution of the macro. 
<p>

<b>exit("error message")</b><br>
Terminates execution of the macro and displays an error message. 
<p>
ctrueden commented 5 years ago

@haesleinhuepf I tried to update the locally bundled functions.html resource to finish addressing this issue, but it seems there are many differences between the local copy and the one on the remote site. So I wasn’t sure what the process is for updating it? Did you make modifications manually? If so, do you have automation to remake them when things change? And can we commit that script to the repo? Or if not: would it make sense to create such a script?