imagej / imagej-legacy

ImageJ+ImageJ2 compatibility layer
https://imagej.net/libs/imagej-legacy
BSD 2-Clause "Simplified" License
16 stars 25 forks source link

Avoid duplicate close deadlock #295

Closed hinerm closed 1 year ago

hinerm commented 1 year ago

Closes https://github.com/fiji/fiji/issues/324

hinerm commented 1 year ago

@ctrueden this definitely fixes the deadlock I'm seeing in the current Fiji release. But this change is scary since it touches on image synchronization. I stared at it for a long time and I think this is sensible... no tests fail.. and I played around a bit in Fiji and wasn't able to create any orphaned images (which was my main concern). I just wanted another pair of eyes that this is change isn't missing something obvious.

ctrueden commented 1 year ago

See also Zulip discussion here.