search

imagej / imagej-legacy

ImageJ+ImageJ2 compatibility layer
https://imagej.net/libs/imagej-legacy
BSD 2-Clause "Simplified" License
16 stars 25 forks source link

Fix windows test with maven-surefire-plugin 3.1.2 #298

Closed hinerm closed 1 year ago

hinerm commented 1 year ago

Fixes the MacroTest.testBarePluginFromMacro failure on Windows.

NB: this test still fails with Java 11 even with this fix (with the same failure and error message), but passes with Java 8.

Closes #198

hinerm commented 1 year ago

@ctrueden do you know why this workaround was removed?

Is there a reason not to push this maven-surefire-plugin.version to pom-scijava-base?

ctrueden commented 1 year ago

@hinerm I don't remember for sure, but I probably removed the pinned maven-surefire-plugin version because there was no comment attached to it, and it looked like something that should be getting inherited from pom-scijava-base.

It's been awhile since I updated all the plugin versions on pom-scijava-base. I will do that now.