The LegacyUI currently implements SwingUI. This causes it to detect as compatible for things like the SwingTableDisplayViewer, which tests ui instanceof SwingUI. However, we also have a LegacyTextDisplayViewer which does nothing else but override isCompatible to test ui instanceof LegacyUI. So it seems this LegacyTextDisplayViewer is unnecessary, since the superclass (SwingTextDisplayViewer) test of ui instanceof SwingUI will already return true.
Should we:
Make LegacyUI not implement SwingUI?
We would lose extensibility, since we would then need to add a LegacyTableDisplayViewer and potentially other viewers.
Remove the superfluous SwingTextDisplayViewer?
This is the option I'm leaning toward. Then all SwingUI stuff will automatically work in the legacy UI.
The
LegacyUI
currently implementsSwingUI
. This causes it to detect as compatible for things like theSwingTableDisplayViewer
, which testsui instanceof SwingUI
. However, we also have aLegacyTextDisplayViewer
which does nothing else but overrideisCompatible
to testui instanceof LegacyUI
. So it seems thisLegacyTextDisplayViewer
is unnecessary, since the superclass (SwingTextDisplayViewer
) test ofui instanceof SwingUI
will already return true.Should we:
LegacyUI
not implementSwingUI
?LegacyTableDisplayViewer
and potentially other viewers.SwingTextDisplayViewer
?SwingUI
stuff will automatically work in the legacy UI.