imagej / imagej-legacy

ImageJ+ImageJ2 compatibility layer
https://imagej.net/libs/imagej-legacy
BSD 2-Clause "Simplified" License
16 stars 25 forks source link

Decide on UserInterface hierarchy #93

Open ctrueden opened 9 years ago

ctrueden commented 9 years ago

The LegacyUI currently implements SwingUI. This causes it to detect as compatible for things like the SwingTableDisplayViewer, which tests ui instanceof SwingUI. However, we also have a LegacyTextDisplayViewer which does nothing else but override isCompatible to test ui instanceof LegacyUI. So it seems this LegacyTextDisplayViewer is unnecessary, since the superclass (SwingTextDisplayViewer) test of ui instanceof SwingUI will already return true.

Should we:

ctrueden commented 9 years ago

@hinerm Thoughts?

hinerm commented 9 years ago

@ctrueden did you mean, remove the superfluous LegacyTextDisplayViewer? If so, yeah I'm in favor of that as well...

I wish I had documented why I thought I needed it in the first place!