search

imagej / imagej-maven-plugin

[OBSOLETE] All goals migrated to scijava/scijava-maven-plugin
Other
4 stars 6 forks source link

Add JAR classifiers as used by LWJGL #18

Closed skalarproduktraum closed 6 years ago

skalarproduktraum commented 6 years ago

This PR adds the JAR classifiers

to AbstractCopyJarsMojo's versionPattern, so these JARs do not get mistaken for the actual regular JARs.

imagejan commented 6 years ago

For some context, see this lengthy thread on the forum.

skalarproduktraum commented 6 years ago

@imagejan: Damnit, this was unintended, I'll fix that mess and force push...

stelfrich commented 6 years ago

Could you rebase your branch over master, @skalarproduktraum? Should be no hassle. Also, I have filed a PR with an integration test in your fork. Could you merge that one as well? mvn clean install shouldn't complain any longer after that...

skalarproduktraum commented 6 years ago

Done, thanks @stelfrich!

stelfrich commented 6 years ago

This is good to merge, @ctrueden!

ctrueden commented 6 years ago

@stelfrich Thanks. You should have the rights to merge things yourself. If not, let me know and I'll investigate.

stelfrich commented 6 years ago

You should have the rights to merge things yourself. If not, let me know and I'll investigate.

It's not about the rights, @ctrueden, but taking over responsibility 😃

ctrueden commented 6 years ago

@stelfrich Fair enough. But I'll point out that you are de facto responsible for these changes anyway, since I do not have time to review, test or verify the changes myself right now. If something breaks, either you'll have to figure out what is going on and fix it, or else I'll just revert the merge because I don't have time to debug it.