search

imagej / imagej-maven-plugin

[OBSOLETE] All goals migrated to scijava/scijava-maven-plugin
Other
4 stars 6 forks source link

Add an optional imagej.app.subdirectory property #22

Closed ctrueden closed 7 years ago

ctrueden commented 7 years ago

This enables users to have their plugins copied to a subfolder of ImageJ's jars or plugins.

Continuation of #17.

ctrueden commented 7 years ago

Ergh, looks like the integration tests don't pass. In order for this to merge: A) all existing ITs must pass; and B) there must be a new IT exercising this new imagejSubdirectory property. I do not have time to work on it, but @lacan and/or @stelfrich, please feel free if you have time.

@lacan I invited you to a team with write access to this repository, so that you can work on the imagej-subdir branch directly and hence update this PR directly by pushing/force-pushing.

stelfrich commented 7 years ago

@lacan I have reworked your commits on the recursive delete.other.versions into one single commit, removing the changes to the POM. Hence, you should continue working on this branch, which has all the relevant changes from your fork.

I have also added an integration test that models installing Example_PlugIn-1.0.0-SNAPSHOT.jar into plugins/Test2/ of an ImageJ.app directory in which plugins/Test/Example_PlugIn-0.9.0-obsolete.jar already exists. In this scenario, Example_PlugIn-0.9.0-obsolete.jar should be removed in favor of the new version which is installed into a new subdirectory.

This test is currently failing (as well as the ones related to the delete.other.versions logic).

ctrueden commented 7 years ago

@stelfrich @lacan Is this PR ready for merge? Or not yet?

stelfrich commented 7 years ago

Is this PR ready for merge? Or not yet?

I would like to wait for feedback from @lacan since he is/was the one pushing this PR and most likely the one to use it on a daily basis it seems. If that's ok with you @lacan, I will merge it once we have feedback or by the end of the week (whatever comes first).