Add imagej.deleteOtherVersions property

imagej / imagej-maven-plugin

[OBSOLETE] All goals migrated to scijava/scijava-maven-plugin

Other

4 stars 6 forks source link

Add imagej.deleteOtherVersions property #24

Closed stelfrich closed 7 years ago

stelfrich commented 7 years ago

Add a property to define overwriting behavior in more fine-grained manner (when compared to delete.other.versions):

imagej.deleteOtherVersions=never: do not overwrite files in destination
imagej.deleteOtherVersions=always: do always overwrite existing files in destination
imagej.deleteOtherVersions=older: overwrite older versions (i.e. keep newer ones)

This deprecates the old delete.other.versions and will show a warning whenever it is explicitly set. If it is not set, the expected behavior is kept.

stelfrich commented 7 years ago

Taking inspiration from #10, we could include imagej.deleteOtherVersions=incompatible to delete other versions if it is incompatible according to SemVer, i.e. a different major version.

stelfrich commented 7 years ago

we could include imagej.deleteOtherVersions=incompatible to delete

After a short discussion with @ctrueden, we have decided to not implement that as a separate option but give a warning if imagej.deleteOtherVersions=older and you are overwriting with an incompatible version.

stelfrich commented 7 years ago

Thanks to a lot of help from @ctrueden (seriously: thanks for https://github.com/scijava/scijava-common/commit/82ce585ca0a676d12ee1f612664766cb1ac1cd4d!) this is good to merge once scijava-common:2.66.0 is released.

ehrenfeu commented 6 years ago

This should also be reflected in the corresponding section of the Developing ImageJ in Eclipse page, right? If you agree, I can simply update the wiki...

stelfrich commented 6 years ago

Good catch @ehrenfeu. Feel free to update the wiki - I would appreciate it :+1:

ehrenfeu commented 6 years ago

Done :heavy_check_mark: