search

imagej / imagej-maven-plugin

[OBSOLETE] All goals migrated to scijava/scijava-maven-plugin
Other
4 stars 6 forks source link

Use POM.compareTo() instead of VersionUtils.compare() #29

Closed stelfrich closed 5 years ago

stelfrich commented 6 years ago

Use POM.compareTo() (introduded in https://github.com/scijava/scijava-common/commit/c02cca436460a11bbcde3fe51f062019153a756b) instead of VersionUtils.compare() when checking for newer/older versions of an artifact in AbstractCopyJarsMojo.java#L184.

imagejan commented 6 years ago

Why not the other way around, use VersionUtils.compare() in all places where POM.compareTo() is currently used? As @ctrueden mentioned on gitter:

It is in the wrong place. We can fix it.

stelfrich commented 5 years ago

Good point, @imagejan!

See also https://github.com/scijava/scijava-common/issues/334.