imagej / imagej-ops

ImageJ Ops: "Write once, run anywhere" image processing
https://imagej.net/libs/imagej-ops
BSD 2-Clause "Simplified" License
88 stars 42 forks source link

Parallize BoxCount with more than 1 'translation' #616

Closed rimadoma closed 4 years ago

rimadoma commented 4 years ago

Following issue 196 on the BoneJ2 hub, speeds up the BoxCounting op, when user has requested more than one "translation". Translations move the boxes around in hopes of finding the best fit, but add work in O(n^d) fashion.

I tried the obvious strategy of parallizing the boxes first, but that didn't run much faster.

ctrueden commented 4 years ago

Thanks @rimadoma.

@gselzer We'll need to port this work to scijava-ops, right?

gselzer commented 4 years ago

@ctrueden yeah, this will have to be ported. I'll add it to my list

gselzer commented 4 years ago

@ctrueden changes are now ported to scijava-ops work

rimadoma commented 4 years ago

@gselzer Thank you! Should I commit future changes there?

gselzer commented 4 years ago

@rimadoma so we currently have all of the ops within imagej-ops copied into scijava-ops (see this branch) so that they could be updated to use the new Op framework. Eventually all of the ops, as well as this work, will all make its way back into the imagej-ops repository, once all of the work on scijava-ops is finalized. So long story short, probably not :grin: