imagej / imagej-scripting

ImageJ-specific applications of the SciJava script languages
Other
25 stars 15 forks source link

Add a test framework for scripts #17

Closed hadim closed 7 years ago

hadim commented 7 years ago

See https://github.com/imagej/imagej-scripting/pull/16 for the record.

hadim commented 7 years ago

LGTM for me.

bnorthan commented 7 years ago

@hadim when I build with 'mvn' from the command line, several tests produce the following message (though the tests appear to actually pass)

[ERROR] Cannot create plugin: class='net.imagej.table.process.ResultsPostprocessor', priority=-9999.0, enabled=true, pluginType=PostprocessorPlugin java.lang.IllegalArgumentException: Required service is missing: org.scijava.ui.UIService

hadim commented 7 years ago

The last commit should remove the error message.

bnorthan commented 7 years ago

Hi @hadim it now works for me. Great!. It looks good overall. Did you run autoformat ctrlshiftf?? Looked like there were a couple misalignments in some of the files. Otherwise it looks good and I would be happy to merge this.

hadim commented 7 years ago

I run auto-format on all the files. Fell free to merge when you want.