search

imagej / imagej-scripting

ImageJ-specific applications of the SciJava script languages
Other
25 stars 15 forks source link

Use Ops instead of"Diffraction PSF 3D" command to create PSF #35

Closed ctrueden closed 2 years ago

ctrueden commented 2 years ago

The DeconWithChirpImg.groovy script currently calls IJ.run("Diffraction PSF 3D", ...) to create a PSF. But since that script was written, @bnorthan added a create.kernelDiffraction op to generate Gibson Lanni kernels based on code from Jizhou Li. So we should update this script accordingly to use it, right?

ctrueden commented 2 years ago

I see that DeconWithTheoreticalPSF.py already uses create.kernelDiffraction... @bnorthan is my understanding correct that DeconWithChirpImg.groovy could use it as well? Or is the "Diffraction PSF 3D" function doing something else? (If so, please feel free to close this issue.)

imagesc-bot commented 2 years ago

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/exponential-chirp-decon-test/1183/2

bnorthan commented 2 years ago

Hi @ctrueden

I just submitted a small pull request which changes the script to use create.kernelDiffraction .

ctrueden commented 2 years ago

Fixed by #36. Thanks, @bnorthan!