Closed etadobson closed 8 years ago
@ctrueden @bnorthan take a look. in the comments - i just indicated the images to use within each tutorial... hopefully it's more clear now for the users.
@bnorthan I asked @ctrueden about this and he mentioned that he was going to let you look at this one. would you mind taking a quick look that you agree with these comments? Thanks! :octopus:
Thanks @bnorthan -- I'll make those changes ...
@bnorthan -- changes have been made. take a look...
Looks great. @etarena is there anything else you want to add?? If not I can merge it.
@bnorthan nope - we're all good.
@bnorthan done.
Awesome!
@bnorthan @etarena so I was the one who said each commit message should have some identifier differentiating where the change was located. This is actually valuable information as it allows someone to glance at the commit messages and know (or at least have a suggestion) the location of the changes int hat commit. If the messages were undesirable or confusing, I would have made them more specific instead of less.
This article is a great one on Git commit messages, since it links back to practical examples - like Linux and Git - which illustrate meticulous documentation in their commits messages and titles.
There are always other ways of discovering this information, but a commit message is typically your "first line of defense" for conveying information to other developers... so if we use duplicate messages we are missing an opportunity for communication.
@hinerm oops.
I agree with @hinerm!
Although in this case, these changes were so small they probably could have just been a single commit with message "Document recommended images" to avoid the whole issue. :wink:
@etarena it's fine. I did not give a good explanation of why I was telling you to put those prefixes there in the first place.
"Document recommended images" to avoid the whole issue.
This is true... but more commits = more complex rebase = more fun!
@hinerm ... now that you said that - I remember having that 'specific' conversation on 'specificity'... lesson double-learned. ;) (at least i got the hang of intro-to-rebasing!)
@hinerm, @ctrueden, @etarena
OK that makes sense. Sounds like duplicate commit messages should be avoided after all.
Comments have been added to indicate to users the images to use within individual tutorials.