search

imagej / imagej-ui-swing

ImageJ UI for Java Swing.
BSD 2-Clause "Simplified" License
10 stars 20 forks source link

SitesDialog: fix appearing of previous URL #76

Closed stelfrich closed 6 years ago

stelfrich commented 7 years ago

Removing a row that was still edited from the manage update sites dialog resulted in validity checks which are actually unnecessary for a site that is removed and prohibited proper stopping of the editing process. This in turn resulted in the URL of a previous editing to reappear once you add a new update site.

stelfrich commented 6 years ago

Steps to reproduce the issue:

  1. Help > Update...
  2. Manage update sites
  3. Add update site
  4. Insert bogus URL (abcde)
  5. OK
  6. Remove
  7. Yes
  8. Add update site

Inserts a new update site with the bogus URL and shows an error message. Should, however, actually start with an empty row without errors.

imagejan commented 6 years ago

I just noticed that there's still/again a branch fix-remove-after-exception.

@stelfrich it seems that you pushed after this PR was merged, right? Should the remaining changes (see link above) be merged as well?

stelfrich commented 6 years ago

Thanks for noticing, @imagejan! I have deleted the branch since I couldn't find any additional issues that this might have fixed (in a a long forgotten past...).