The current test for uploading is pretending things are working when they are not.
The current webdav uploader has a reflection hack overriding the default GET method of a HTTP request by special ones like DELETE or OPTIONS. For HTTPS, this hack does not work. Therefore, when assuming the DELETE method is called, the GET method is called instead. In case the file is present, it returns 200 - all good. The test is assuming deleting worked and continues..
This PR adds a test if deleted files really don't exist anymore afterwards. It also adds a boolean isDeleted(String path) function to Deleter interface. Other Uploaders must implement this method, otherwise NotImplementedException is thrown when running this test. The Exception is the reason why I added the commons-lang dependency..
Not happy with the naming of isUpdateSiteEmpty() either since the test is only checking if the db.xml.gz is present.. But since it's a public method I was not sure about renaming it.
frauzufall
commented
5 years ago
The current test for uploading is pretending things are working when they are not.
The current webdav uploader has a reflection hack overriding the default GET method of a HTTP request by special ones like
DELETEorOPTIONS. For HTTPS, this hack does not work. Therefore, when assuming the DELETE method is called, the GET method is called instead. In case the file is present, it returns200- all good. The test is assuming deleting worked and continues..This PR adds a test if deleted files really don't exist anymore afterwards. It also adds a
boolean isDeleted(String path)function to Deleter interface. Other Uploaders must implement this method, otherwiseNotImplementedExceptionis thrown when running this test. The Exception is the reason why I added thecommons-langdependency..Not happy with the naming of
isUpdateSiteEmpty()either since the test is only checking if thedb.xml.gzis present.. But since it's a public method I was not sure about renaming it.