Improve offline handling

imagej / imagej-updater

The automatic updater for ImageJ

Other

12 stars 15 forks source link

Improve offline handling #81

Closed frauzufall closed 4 years ago

frauzufall commented 5 years ago

UpToDate::check: catch UnknownHostException
UpToDate::check: return OFFLINE if HTTPSUtil had no connection
HTTPSUtil::noConnection indicating whether HTTPS check could not connect to network

ctrueden commented 5 years ago

Great! Code looks very clean.

One question. Right now this code statically caches failure, with no possibility to "go online" once the first update check fails. Presumably, ImageJ would need to be restarted after the user enables networking. Would it be better to repeat the up-to-date check each time the code is invoked, in case the network status has changed since last time? Then a restart wouldn't be necessary.

frauzufall commented 4 years ago

Hi @ctrueden, thanks for the review and sorry for the late response! I changed the code so that the offline status is forgotten on a next HTTPS check.

ctrueden commented 4 years ago

Thanks, @frauzufall !