`Replace All` in Script Editor always says "0 Replacements Made!" - Githubissues

imagej / imagej2

Open scientific N-dimensional image processing :microscope: :sparkler:

https://imagej.net/

BSD 2-Clause "Simplified" License

1.2k stars 337 forks source link

`Replace All` in Script Editor always says "0 Replacements Made!" #187

Closed AVHon closed 6 years ago

AVHon commented 6 years ago

To reproduce:

Select "Plugins" -> "New" -> "Macro" to open the script editor
Add any text to the file
Select "Edit" -> "Find and Replace..."
In the "Find Next" field, put some text that occurs n times in the file, where n>=1.
Add any text to the "Replace with" field
Click "Replace All"

What happens:

All occurrences of the "Find Next" text are replaced with the "Replace With" text.
A popup announces "0 Replacements Made!"

What should happen:

All occurrences of the "Find Next" text are replaced with the "Replace With" text.
A popup announces "n Replacements Made!"

ImageJ 1.51s, Java 1.8.0_66 (64-bit)

imagejan commented 6 years ago

Thanks for spotting this. I was able to reproduce it and fixed it in https://github.com/scijava/script-editor/pull/13. The fix will be available in Fiji once a new script-editor release is cut and uploaded to the update site.