imagekit-developer / imagekit-angular

Angular SDK for ImageKit.io client side file upload and URL generation
https://imagekit.io
18 stars 20 forks source link

Sdk v2 upgrade #43

Closed dev-codesymphony closed 1 year ago

dev-codesymphony commented 1 year ago

Sdk v2 upgrade

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b23c2e4). Click here to learn what that means. Patch has no changes to coverable lines.

:exclamation: Current head df5a858 differs from pull request most recent head 2d5a537. Consider uploading reports for the commit 2d5a537 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #43 +/- ## ========================================= Coverage ? 92.05% ========================================= Files ? 6 Lines ? 277 Branches ? 52 ========================================= Hits ? 255 Misses ? 4 Partials ? 18 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ngyongzhen commented 1 year ago

Sample app should be moved to quick start repo. Readme.md should be updated as well.

Resolved

imagekitio commented 1 year ago

Sample app should be moved to quick start repo. Readme.md should be updated as well.

Resolved

Where is the corresponding PR in quickstart samples project?

imagekitio commented 1 year ago

We should restructure all test cases related code and put it inside tests folder as per React. We should not keep it in src folder. image

Not resolved

ngyongzhen commented 1 year ago

We should restructure all test cases related code and put it inside tests folder as per React. We should not keep it in src folder. image

Not resolved

I took out the tests from src and put them all into tests folder - what is the gap here?

Screenshot 2023-02-08 at 1 43 42 PM