search

imagekit-developer / imagekit-javascript

Javascript SDK for using ImageKit.io
https://imagekit.io
77 stars 26 forks source link

Fix/rm authentication url logic #77

Closed prasoon0909 closed 1 year ago

prasoon0909 commented 1 year ago
  1. Removed authentication endpoint from SDK initialisation.
  2. Removed authentication endpoint related logic.
  3. Added security parameters(signature, token and expire) directly to upload method as part of UploadOptions parameter.
  4. Added test case for missing security parameters.
  5. Removed test cases related to authentication endpoint flow test coverage.
  6. Modified test cases to incorporate the changes after removing authentication endpoint flow.
  7. Removed auth endpoint from sample app and moved the generating logic of security parameters inside the base route and passing the security parameters directly to upload method of javascript sdk.
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.15% :tada:

Comparison is base (0ac3953) 95.39% compared to head (ade82ed) 95.54%.

:exclamation: Current head ade82ed differs from pull request most recent head 8e40b10. Consider uploading reports for the commit 8e40b10 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #77 +/- ## ========================================== + Coverage 95.39% 95.54% +0.15% ========================================== Files 9 9 Lines 217 202 -15 Branches 47 50 +3 ========================================== - Hits 207 193 -14 + Misses 2 1 -1 Partials 8 8 ``` | [Files Changed](https://app.codecov.io/gh/imagekit-developer/imagekit-javascript/pull/77?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/constants/errorMessages.ts](https://app.codecov.io/gh/imagekit-developer/imagekit-javascript/pull/77?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2NvbnN0YW50cy9lcnJvck1lc3NhZ2VzLnRz) | `100.00% <ø> (ø)` | | | [src/upload/index.ts](https://app.codecov.io/gh/imagekit-developer/imagekit-javascript/pull/77?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3VwbG9hZC9pbmRleC50cw==) | `97.77% <100.00%> (+0.80%)` | :arrow_up: | | [src/utils/request.ts](https://app.codecov.io/gh/imagekit-developer/imagekit-javascript/pull/77?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3V0aWxzL3JlcXVlc3QudHM=) | `97.22% <100.00%> (+0.39%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.