search

imagekit-developer / imagekit-ruby

Ruby On Rails SDK for ImageKit.io API.
https://imagekit.io
MIT License
19 stars 10 forks source link

Why the dependency on CarrierWave? #55

Closed tamoyal closed 1 year ago

tamoyal commented 1 year ago

I'm confused about the dependency on Carrier Wave given it's an optional setting. I am looking to use the SDK in a plain ruby environment and would prefer no unnecessary dependencies.

imagekitio commented 1 year ago

There is a PR https://github.com/imagekit-developer/imagekit-ruby/pull/54/files related to this. We will review and test this soon.

stefanahman commented 1 year ago

@tamoyal they just closed my PR without giving any feedback. We ended up not using the gem/service. I hope you solve your problems in some other way!

imagekitio commented 1 year ago

The latest version 2.3.0 has the fix and necessary changes from that closed PR. Please check and open this issue if needed.

tamoyal commented 1 year ago

@stefanahman Yea we decided to not move forward with it as well. Thanks for letting me know!

cspeer commented 1 year ago

With 2.3.0 I'm seeing the following exception: `/gems/imagekitio-2.3.0/lib/carrierwave/storage/imagekit_store.rb:8:in': uninitialized constant CarrierWave (NameError)```

the app does not use carrierwave. so it looks like it's still dependent on carrierwave somehow?