search

imagemin / imagemin-pngquant

Imagemin plugin for `pngquant`
MIT License
316 stars 81 forks source link

Don't throw on inputs larger than 10 MB #52

Closed knokmki612 closed 5 years ago

knokmki612 commented 5 years ago

I'm using imagemin-pngquant with gulp-imagemin, and I encountered a problem when imagemin-pngquant processes many png files like this:

$ gulp imagemin
[12:25:08] Using gulpfile ~/Workspace/gulpfile.js
[12:25:08] Starting 'imagemin'...
[12:33:15] Plumber found unhandled error:
 Error in plugin 'gulp-imagemin'
Message:
    stdout maxBuffer exceeded
Details:
    stream: stdout
    fileName: /Users/kimiaki/Workspace/src/img/screen_shot/press_menu_PC.png
[12:43:06] gulp-imagemin: Minified 135 images (saved 45.3 MB - 64.4%)
[12:43:06] Finished 'imagemin' after 18 min
$

I looked into source and found index.js are using execa, it sets default maxBuffer to 10MB.

Then I looked imagemin-mozjpeg, it sets Infinity to maxBuffer.

This pull request sets execa options same as imagemin-mozjpeg, to prevent maxBuffer exceeding.

knokmki612 commented 5 years ago

thanks